🌱 Update release notes tool to handle multiples_areas and colons #12738
Conversation
k8s-ci-robot
added
area/release
k8s-ci-robot
added
the
size/S
chandankumar4
changed the title
hack/tools/release/notes/process.go
Outdated
| return entry | ||
| } | ||
|
|
||
| // UpdateTitle updates a title by removing the "MULTIPLE_AREAS[]" substrings and multiple colons(:). |
There was a problem hiding this comment.
Q: When does the "multiple colon" case happen?
hack/tools/release/notes/process.go
Outdated
| // UpdateTitle updates a title by removing the "MULTIPLE_AREAS[]" substrings and multiple colons(:). | ||
| func updateTitle(input string) string { | ||
| // Remove "MULTIPLE_AREAS[" from the input | ||
| input = strings.Replace(input, "MULTIPLE_AREAS[", "", 1) |
There was a problem hiding this comment.
What about simply not adding MULTIPLE_AREAS wherever we do that, so that we don't have to remove it here again?
Signed-off-by: chandankumar4 <[email protected]>
chandankumar4
force-pushed
the
update-release-notes
branch
from
a32eaad to
eecc038
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| } | ||
|
|
||
| // UpdateTitle updates a title by removing the multiple colons(:). | ||
| func updateTitle(input string) string { |
There was a problem hiding this comment.
What cases are we fixing here? Let's please add unit test coverage
There was a problem hiding this comment.
Where are these colons coming from? (would be good to have an example to understand why we need this)
3 participants
What this PR does / why we need it:
MULTIPLE_AREASin the generated notesMULTIPLE_AREAS[KCP/CABPK]: Change envVars fields from []EnvVar to *[]EnvVar (#12539)toKCP/CABPK: Change envVars fields from []EnvVar to *[]EnvVar (#12539)Testing:Framework: Watch logs from init containers (#12208)toTesting/Framework: Watch logs from init containers (#12208)Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes: #12280
/area release